Request for code review - 8130265: gctests/LargeObjects/large001 fails with OutOfMemoryError: Java heap space

[Alexander Harlap]

Kim and Thomas,

Here is new version with your suggestions in:

http://cr.openjdk.java.net/~aharlap/8130265/webrev.03/
<http://cr.openjdk.java.net/%7Eaharlap/8130265/webrev.03/>
Alex

On 8/20/2015 11:01 AM, Thomas Schatzl wrote:
> Hi Alex,
>
> On Wed, 2015-08-19 at 18:43 -0400, Kim Barrett wrote:
>> On Aug 19, 2015, at 5:02 PM, Alexander Harlap <alexander.harlap at oracle.com> wrote:
>>> I agree.
>>>
>>> Here is new revision:
>>>
>>> http://cr.openjdk.java.net/~aharlap/8130265/webrev.02/
>>> <http://cr.openjdk.java.net/%7Eaharlap/8130265/webrev.02/>
>    would it be possible to fix the code duplication between lines
> 1759-1784 and 1785 and 1812? The code seems to be completely the same
> except the different flag value passed to the Full GC call and the
> assert about that should_clear_all_soft_refs().
>
> Otherwise it looks good.
>
> Thanks,
>    Thomas
>
>
>