RFR (S): 8144714 Add extension point to G1 evacuation closures
Jon Masamitsu
jon.masamitsu at oracle.com
Mon Dec 7 18:04:04 UTC 2015
On 12/07/2015 12:36 AM, David Lindholm wrote:
> On 2015-12-05 22:30, Kim Barrett wrote:
>> On Dec 4, 2015, at 12:42 PM, Jon Masamitsu <jon.masamitsu at oracle.com>
>> wrote:
>>> http://cr.openjdk.java.net/~mgerdin/8144714/webrev.0/src/share/vm/gc/g1/g1ParScanThreadState_ext.cpp.frames.html
>>>
>>>
>>> Lines 39 and 40 not particularly useful?
>>>
>>> 37 template void G1ParScanThreadState::do_oop_ext<oop>(oop* ref);
>>> 38 template void
>>> G1ParScanThreadState::do_oop_ext<narrowOop>(narrowOop* ref);
>>> 39
>>> 40
>> These are explicit instantiations of the immediately preceding
>> definition.
>>
>
> They look like empty lines to me. :-)
Yes, I should speak more plainly.
Jon
> Erik also pointed out that there is one extra newline at the end of
> this file, and that should be fixed before the push.
>
> Thanks,
> /David
More information about the hotspot-gc-dev
mailing list