RFR (S): 8143215: gcc 4.1.2: fix three issues breaking the build.

[Lindenmaier, Goetz]

Hi Kim,

> Looks good.
Thanks! I'm very relieved :)

Ouch ... I wanted to make a new webrev including all the reviewers 
and rebased, and found this:
concurrentMarkSweepGeneration.cpp:2734: warning: converting to jlong from double
g1CollectedHeap.cpp:3624: warning: passing double for argument 1 to static double TimeHelper::counter_to_seconds(jlong)

I corrected this in this new webrev, I hope this doesn't cause another long
round of reviews (please!).
http://cr.openjdk.java.net/~goetz/webrevs/8143215-gcc412/webrev.04/

Best regards,
  Goetz.

Incremental change:

diff -r 73e267ddd93d src/share/vm/gc/cms/concurrentMarkSweepGeneration.cpp
--- a/src/share/vm/gc/cms/concurrentMarkSweepGeneration.cpp     Wed Nov 18 11:31:59 2015 +0100
+++ b/src/share/vm/gc/cms/concurrentMarkSweepGeneration.cpp     Fri Dec 11 11:42:52 2015 +0100
@@ -2731,7 +2731,7 @@
   // Not MT-safe; so do not pass around these StackObj's
   // where they may be accessed by other threads.
   jlong wallclock_millis() {
-    return TimeHelper::counter_to_millis(os::elapsed_counter() - _trace_time.start_time());
+    return (jlong)TimeHelper::counter_to_millis(os::elapsed_counter() - _trace_time.start_time());
   }
 };

diff -r 73e267ddd93d src/share/vm/gc/g1/g1CollectedHeap.cpp
--- a/src/share/vm/gc/g1/g1CollectedHeap.cpp    Wed Nov 18 11:31:59 2015 +0100
+++ b/src/share/vm/gc/g1/g1CollectedHeap.cpp    Fri Dec 11 11:42:52 2015 +0100
@@ -3621,7 +3621,7 @@
     log_info(gc)("To-space exhausted");
   }

-  double pause_time_sec = TimeHelper::counter_to_seconds(pause_time_counter);
+  double pause_time_sec = TimeHelper::counter_to_seconds((jlong)pause_time_counter);
   g1_policy()->print_phases(pause_time_sec);

   g1_policy()->print_detailed_heap_transition();


> -----Original Message-----
> From: Kim Barrett [mailto:kim.barrett at oracle.com]
> Sent: Freitag, 11. Dezember 2015 00:59
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Cc: hotspot-gc-dev at openjdk.java.net
> Subject: Re: RFR (S): 8143215: gcc 4.1.2: fix three issues breaking the build.
> 
> On Dec 10, 2015, at 4:18 AM, Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com> wrote:
> >
> > Hi,
> >
> > Seeing Mikaels mail, I did not convert the computation in
> > g1IHOPControl.cpp:145 ff.
> 
> OK.  I'll file an RFE for that.
> 
> > I changed though the computations in gcTraceSend.cpp.
> > Please check whether I should move the division to
> > be performed before the multiplication.
> 
> I checked these, and they are ok in your latest version.
> 
> >
> > See more comments inline below.
> >
> > New webrev:
> > http://cr.openjdk.java.net/~goetz/webrevs/8143215-
> gcc412/webrev.03/index.html
> 
> Looks good.
> 
> >> get_new_size_prediction?  get_predicted_size?  Let the bikeshedding
> >> begin!
> > I introduced get_new_size_prediction() as Mikael said.
> 
> Mikael => Thomas.