RFR: 8144996: Replace the HeapRegionSetCount class with an uint

David Lindholm david.lindholm at oracle.com
Fri Dec 11 13:04:12 UTC 2015


Jesper,

Thanks for the review!

/David

On 2015-12-11 14:08, Jesper Wilhelmsson wrote:
> Looks good!
> /Jesper
>
> Den 11/12/15 kl. 13:39, skrev Bengt Rutisson:
>>
>> Hi David,
>>
>> On 2015-12-11 13:16, David Lindholm wrote:
>>> Hi,
>>>
>>> After offline discussions with Bengt we decided that
>>> HeapRegionSetBase::total_capacity_bytes() also can be removed.
>>>
>>> New webrev:
>>>
>>> http://cr.openjdk.java.net/~david/JDK-8144996/webrev.01/
>>
>> Looks good to me.
>>
>> Bengt
>>
>>>
>>> Thanks,
>>> David
>>>
>>> On 2015-12-10 17:45, David Lindholm wrote:
>>>> Hi,
>>>>
>>>> Please review this cleanup patch that removes the 
>>>> HeapRegionSetCount class
>>>> and replaces it with an uint.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8144996
>>>> Webrev: http://cr.openjdk.java.net/~david/JDK-8144996/webrev.00/
>>>>
>>>> Testing: JPRT and running jmap executing the heapsummary command 
>>>> verifying
>>>> that it still print correct values.
>>>>
>>>>
>>>> Thanks,
>>>> David
>>>
>>




More information about the hotspot-gc-dev mailing list