RFR: JDK-8145303: Clean up the units for log_gc_footer

Bengt Rutisson bengt.rutisson at oracle.com
Mon Dec 14 10:56:30 UTC 2015


Hi Thomas,

On 2015-12-14 11:51, Thomas Schatzl wrote:
> Hi Bengt,
>
> On Mon, 2015-12-14 at 10:42 +0100, Bengt Rutisson wrote:
>> Hi everyone,
>>
>> Could I have a couple of reviews for this small patch?
>>
>> http://cr.openjdk.java.net/~brutisso/8145303/webrev.00/
>> https://bugs.openjdk.java.net/browse/JDK-8145303
>>
>> The log_gc_footer() method takes one parameter of type double. But it
>> should be jlong. It also converts to seconds but farther down the call
>> chain we convert to milliseconds.
>    do you mind removing the line "double pause_start_sec =
> os::elapsedTime()" in g1CollectedHeap.cpp:3717 just above that change in
> 3718. It's dead code.
>
> Do not need another review for that.

Good catch. I'll fix that.

Thanks for looking at this!

Bengt

>
> Thanks,
>    Thomas
>
>




More information about the hotspot-gc-dev mailing list