RFR (S): 8143215: gcc 4.1.2: fix three issues breaking the build.

[Lindenmaier, Goetz]

Hi Kim,

I removed the change to the flag:
http://cr.openjdk.java.net/~goetz/webrevs/8143215-gcc412/webrev.06
I also moved the comment as Thomas asked for.

Would you sponsor this?

Thanks,
  Goetz.


> -----Original Message-----
> From: Kim Barrett [mailto:kim.barrett at oracle.com]
> Sent: Montag, 14. Dezember 2015 23:39
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Cc: Thomas Schatzl <thomas.schatzl at oracle.com>; Bengt Rutisson
> <bengt.rutisson at oracle.com>; hotspot-gc-dev at openjdk.java.net
> Subject: Re: RFR (S): 8143215: gcc 4.1.2: fix three issues breaking the build.
> 
> On Dec 14, 2015, at 3:35 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> >
> >>> On 2015-12-14 12:19, Lindenmaier, Goetz wrote:
> >>>> Hi,
> >>>>
> >>>> I removed the change to g1CollectedHeap.cpp
> >>>> ("8145303: Clean up the units for log_gc_footer" will fix this)
> >>>> and changed the flag to 'double'. New webrev:
> >>>> http://cr.openjdk.java.net/~goetz/webrevs/8143215-
> gcc412/webrev.05/
> >
> > I *think* the simplest change is to make the return type for
> > wallclock_millis be double.  Then it matches type of the value it
> > obtains from TimeHelper::counter_to_millis.  This will lead to a
> > comparison between that double value and the integral
> > CMSMaxAbortablePrecleanTime, but that shouldn't be a problem.
> 
> To be specific, webrev.05 looks good to me if the change to the type of
> CMSMaxAbortablePrecleanTime is backed out.