Request for review (s) - 8145031: Add regression test for 8133023
Thomas Schatzl
thomas.schatzl at oracle.com
Tue Dec 15 10:24:39 UTC 2015
Hi Jon,
On Thu, 2015-12-10 at 11:50 -0800, Jon Masamitsu wrote:
>
> The cause of the failure in 8133023 was the calculation of the
> ParallelGCThreads using
> information that had not yet been initialized. Add a test that checks
> that, after full
> initialization, the fresh calculation of ParallelGCThreads is
> consistent with the value
> calculated earlier.
>
> http://cr.openjdk.java.net/~jmasa/8145031/webrev.00/
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8145031
>
> Tested with and without the fix for 8133023.
>
seems okay, with one nit: the indendation of the parameters for the
assert in Abstract_VM_Version::FinalParallelGCThreads_test() seems off.
Also there is an extra space between the "void" and the method name.
I do not need to re-review.
Thanks,
Thomas
More information about the hotspot-gc-dev
mailing list