RFR (S): 8145534: TestRemsetLogging.java takes a long time

Bengt Rutisson bengt.rutisson at oracle.com
Thu Dec 17 11:37:54 UTC 2015


Hi Thomas,

Latest webrev looks good.

Thanks for fixing this!

Bengt

On 2015-12-17 12:03, Thomas Schatzl wrote:
> Hi Bengt,
>
>    thanks for your review,
>
> On Thu, 2015-12-17 at 08:28 +0100, Bengt Rutisson wrote:
>> Hi Thomas,
>>
>> Thanks for fixing this!
>>
>> Changes look good except that I think TestRemsetLogging.java should have
>> the same @requires tag as the other tests.
>>
>> @requires vm.gc=="G1" | vm.gc =="null"
>>
> Fixed.
>
>> Also, I think the 100 seconds runtime that you got may be related to the
>> fastdebug/slowdebug issue that the changes to the configure scripts
>> introduced.
>>
>> The numbers I reported in the bug report (18 seconds) are from my
>> workstation without the slowdebug problem.
>>
>> If I run with your changes I get:
>>
>> elapsed time (seconds): 4.391
>>
>> Which is a great improvement and an acceptable execution time I think.
> :)
>
> New webrev at http://cr.openjdk.java.net/~tschatzl/8145534/webrev.1
> (sorry no diff, I messed up)
>
> Thanks,
>    Thomas
>
>




More information about the hotspot-gc-dev mailing list