RFR (S): 8145534: TestRemsetLogging.java takes a long time

Jon Masamitsu jon.masamitsu at oracle.com
Thu Dec 17 16:35:30 UTC 2015



On 12/17/2015 03:05 AM, Thomas Schatzl wrote:
> Hi Jon,
>
>    thanks for your review.
>
> On Wed, 2015-12-16 at 15:15 -0800, Jon Masamitsu wrote:
>> Thomas,
>>
>> http://cr.openjdk.java.net/~tschatzl/8145534/webrev/test/gc/g1/TestRemsetLoggingThreads.java.frames.html
>>
>> Did you consider adding the -Xint to the execution line above?
> The test only runs the VM with -version. No java code is executed.
>
>> http://cr.openjdk.java.net/~tschatzl/8145534/webrev/test/gc/g1/TestRemsetLoggingPerRegion.java.frames.html
>>
>> Why is the @requires needed above?  It's telling jtreg that
>> TestRemsetLoggingPerRegion
>> needs to be run with G1, right.  Is that really the case?
>>
>> Rest looks good.
> Yes. The option and log message is G1 only.
>
> New webrev at http://cr.openjdk.java.net/~tschatzl/8145534/webrev.1

Looks good.

Jon

> (sorry no diff, I messed up)
>
> Thanks,
>    Thomas
>




More information about the hotspot-gc-dev mailing list