RFR (XXS): 8145673: G1RemSetSummary.hpp uses FREE_C_HEAP_ARRAY

Mikael Gerdin mikael.gerdin at oracle.com
Fri Dec 18 11:37:23 UTC 2015


Hi Thomas,

On 2015-12-18 11:46, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this change that fixes some include problem
> with G1RemSetSummary?
>
> The .hpp file uses FREE_C_HEAP_ARRAY, which is defined in an .inline.hpp
> file. For some reason, g1RemSetSummary.hpp does not even include that
> one, but only relies on other code using it doing the right thing (tm).
>
> The fix is to move the code into the .cpp file and do the correct
> includes.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8145673
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8145673/webrev/

Looks good.
/Mikael

> Testing:
> jprt, build all platforms
>
> Thanks,
>    Thomas
>
>




More information about the hotspot-gc-dev mailing list