RFR (XS): 8145667: Move FromCardCache into separate files

[Mikael Gerdin]

Thomas,

On 2015-12-18 12:48, Thomas Schatzl wrote:
> Hi,
>
> On Fri, 2015-12-18 at 12:42 +0100, Stefan Karlsson wrote:
>> Hi Thomas,
>>
>> On 2015-12-18 11:49, Thomas Schatzl wrote:
>>> Hi all,
>>>
>>>     please review this change that moves the FromCardCache into separate
>>> files. It is pretty much a "self-sustaining" part of remembered set
>>> processing which I think is enough to warrant moving it into a separate
>>> file.
>>> Also it then does not stay in the way when working on remembered set code.
>>>
>>> Follow-up CRs will rename it according to naming conventions
>>> (->G1FromCardCache, JDK-8145671), and some clean-up to remove
>>> dependencies to HeapRegionRemSet (JDK-8145672).
>>>
>>> So this change is purely moving the class into separate files.
>>>
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8145667
>>> Webrev:
>>> http://cr.openjdk.java.net/~tschatzl/8145667/webrev/
>>
>> Looks good, except that you are introducing a new way to end the include
>> guards:
>>
>> #endif  /* SHARE_VM_GC_G1_G1FROMCARDCACHE_HPP */
>>
>> The file you moved the code from uses:
>>
>> #endif // SHARE_VM_GC_G1_HEAPREGIONREMSET_HPP
>>
>>
>> which is the format that was used when the include guards were introduced.
>
> Thanks for the review. Copy and past from the wrong file then :( I will
> fix it in the other G1 files too in another change.
>
> I updated the webrev in place.

Looks good to me.
/Mikael

>
> Thanks,
>    Thomas
>