RFR (XS): 8145674: Fix includes and forward declarations in g1Remset files

Volker Simonis volker.simonis at gmail.com
Fri Dec 18 14:23:12 UTC 2015


OK, you convinced me :)

Thumbs up!

Volker

On Fri, Dec 18, 2015 at 3:15 PM, Thomas Schatzl
<thomas.schatzl at oracle.com> wrote:
> Hi,
>
> On Fri, 2015-12-18 at 14:52 +0100, Volker Simonis wrote:
>> On Fri, Dec 18, 2015 at 12:35 PM, Thomas Schatzl
>> <thomas.schatzl at oracle.com> wrote:
> [...]
>> > I did not remove the HeapRegion* forward declarations after adding
>> > heapRegion.hpp.
>> >
>>
>> I suppose you wanted to say "I did remove...". At least that's what
>> the new webrev says.
>>
>> Why did you had to add "memory/allocation.hpp" now? Was this intentional ?
>>
>> Otherwise looks good.
>
> G1RemSet inherits from CHeapObj :)
>
> Thanks,
>   Thomas
>
>



More information about the hotspot-gc-dev mailing list