RFR (XS): Forward port of 8065331: Add trace events for failed allocations

Marcus Larsson marcus.larsson at oracle.com
Fri Dec 18 15:16:56 UTC 2015


On 2015-12-10 10:26, Bengt Rutisson wrote:
>
> Hi Marcus,
>
> Looks good.

Thanks for reviewing!

Regards,
Marcus

>
> Bengt
>
> On 2015-12-09 12:57, Marcus Larsson wrote:
>> Hi,
>>
>> After offline discussions with Bengt, I've decided to omit the 
>> Pending GCId from the event. The ID used previously was never 
>> guaranteed to be correct, since it came from the peek() method. 
>> Sometimes a GCId would be skipped which then caused some of the 
>> events to have an "invalid" GCId. Grouping these events together with 
>> some GC will now instead have to be done by the event timestamps.
>>
>> New webrev:
>> http://cr.openjdk.java.net/~mlarsson/8065331_to_9/webrev.02/
>>
>> Incremental:
>> http://cr.openjdk.java.net/~mlarsson/8065331_to_9/webrev.01-02/
>>
>> Thanks,
>> Marcus
>>
>> On 2015-12-07 10:27, Marcus Larsson wrote:
>>> Hi all,
>>>
>>> Still need approval for this forward port.
>>>
>>> New webrev due to changes in how GCId works:
>>> http://cr.openjdk.java.net/~mlarsson/8065331_to_9/webrev.01/
>>>
>>> Had to add a peek method in order to find the pending GC id for the 
>>> event.
>>> This and the changes to includes should be the only things differing 
>>> from the original patch.
>>>
>>> Thanks,
>>> Marcus
>>>
>>> On 2015-08-26 12:04, Marcus Larsson wrote:
>>>> Ping!
>>>>
>>>> On 2015-08-24 09:39, Marcus Larsson wrote:
>>>>> Hi,
>>>>>
>>>>> Please review the following patch to forward port the JEP-242 
>>>>> event to JDK9. The patch was originally reviewed in April/March 
>>>>> [1], but was only integrated in 8u60. The original patch no longer 
>>>>> applies cleanly to 9, due to directory restructuring and changes 
>>>>> to includes, so I need a quick re-review for this.
>>>>>
>>>>> The new patch has updated #includes for the new directory 
>>>>> structure but should otherwise be identical to the previous patch.
>>>>>
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~mlarsson/8065331_to_9/webrev.00/
>>>>>
>>>>> Original webrev:
>>>>> http://cr.openjdk.java.net/~mlarsson/8065331/webrev.02/
>>>>>
>>>>> Issue:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8065331
>>>>>
>>>>> Thanks,
>>>>> Marcus
>>>>>
>>>>> [1]: 
>>>>> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2015-March/012408.html
>>>>
>>>
>>
>




More information about the hotspot-gc-dev mailing list