RFR (S): 8145774: Move scrubbing setup code away out of ConcurrentMark

Thomas Schatzl thomas.schatzl at oracle.com
Mon Dec 21 16:21:56 UTC 2015


Hi,

On Mon, 2015-12-21 at 16:39 +0100, Mikael Gerdin wrote:
> Hi,
> 
> On 2015-12-21 16:01, Thomas Schatzl wrote:
> > Hi all,
> >
> >    can I have reviews for this change that moves setup and
> > parallelization detail code for the remset scrubbing code out of
> > ConcurrentMark into G1CollectedHeap?
> >
> > This way, ConcurrentMark does not need a direct reference to G1RemSet
> > and HeapRegionManager any more, and anyway, I think setting up the
> > gangtask by determining the number of threads to use is better suited to
> > be placed into G1CollectedHeap.
> >
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8145774
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8145774/webrev/
> 
> I had a short discussion with Thomas about this with regard to further 
> enhancements but we decided that this change in itself is good to 
> integrate regardless of that.
> It's nice to break down some dependencies between the different G1 
> components.

  thanks for the review.

Fyi, one of the suggested enhancements has been filed in
https://bugs.openjdk.java.net/browse/JDK-8145911.

As mentioned in the initial RFR, the main idea for this change is to
remove some dependencies of the ConcurrentMark class.

Thanks,
  Thomas





More information about the hotspot-gc-dev mailing list