RFR(s): 8144527: NewSizeThreadIncrease would make an overflow

[Michail Chernov]

Hi Sangheon,

Yes, 'null' allows to execute tests with default collector, because you 
use -XX:+UseSerialGC explicitly in your test. If you use only 'Serial', 
test won't be executed with default collector. You can see at 
hotspot/test/gc/g1/* - there are a lot of similar usage of vm.gc in 
@requires tag.

Thanks
Michail

On 23.12.2015 18:44, sangheon.kim at oracle.com wrote:
> Hi Michail,
>
> Thanks for the comment.
>
>> On Dec 23, 2015, at 4:11 AM, Michail Chernov <michail.chernov at oracle.com> wrote:
>>
>> Hi Shangheon,
>>
>> Could you please fix @requires tag. Should be: @requires vm.gc=="Serial" | vm.gc=="null"
> In this test, only serial gc is needed.
> Still 'null' is necessary?
>
>> Also @requires tag should be placed with other tag in one /*..*/ comment, otherwise it doesn't work, see http://openjdk.java.net/jtreg/tag-spec.html#LEADING_COMMENTS .
> This is leftover for local test. :)
> All previous webrev versions were correct but not this one.
>
> Thanks,
> Sangheon
>
>
>> Thanks
>> Michail
>>
>>> Okay.
>>>
>>> To make sure, I'm posting next webrev which includes Mikael's comment.
>>>
>>> Webrev: http://cr.openjdk.java.net/~sangheki/8144527/webrev.02
>>> Testing: JPRT
>>>
>>> Thanks,
>>> Sangheon