RFR: JDK-8068589: GCCause should distinguish jcmd GC.run from System.gc()
kirk at kodewerk.com
Tue Jan 27 17:00:29 UTC 2015
On Jan 27, 2015, at 1:22 PM, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
> Hi Staffan,
> Thank you for your comments.
> I've uploaded new webrev:
> I changed as below:
> - GCCause::_jcmd_gc_run -> GCCause::_dcmd_gc_run
> - GCCause string: "jcmd GC.run" -> "GC.run DCmd”
Can I suggest a shortened GCCause string to “DiagCmd”. At the very least I’d prefer to not have the “.” in the string.
> Could you review it?
> On 2015/01/26 17:12, Staffan Larsen wrote:
>> A bit of terminology here. ‘GC.run’ is called a ‘Diagnostic Command’. ‘jcmd’ is one way to invoke a Diagnostic Command. Another way is via a JMX MBean. With this in mind I think your references to ‘jcmd’ should be changed to ‘diagnostic command’ (or an abbreviation thereof). For example: _jcmd_gc_run -> _dcmd_gc_run.
>>> On 25 jan 2015, at 14:15, Yasumasa Suenaga <yasuenag at gmail.com> wrote:
>>> Hi all,
>>> GCCause which is printed in gc log is "System.gc()" when jcmd GC.run is invoked.
>>> I think that GCCause which is caused by jcmd GC.run should be different from System.gc() .
>>> I uploaded webrev for this enhancement:
>>> This patch prints "jcmd GC.run" to gc log when jcmd GC.run is invoked.
>>> Could you review it?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
More information about the hotspot-gc-dev