RFR: JDK-8077842 - Remove the level parameter passed around in GenCollectedHeap
Kim Barrett
kim.barrett at oracle.com
Wed Jun 3 00:06:09 UTC 2015
On Jun 2, 2015, at 1:56 PM, Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com> wrote:
>
> Hi Kim!
>
> I removed the unrelated formatting changes as suggested to minimize the conflicts with Bill's change. There will still be a conflict though since there were some actual changes as well.
Right. I’m just hoping to make that merge a little easier for whoever ends up needing to do it.
> I also added the is_young_gen()/is_old_gen() in GenCollectedHeap as suggested. There is as you mentioned no way to determine which generation it is inside the generation. I haven't found any good way to implement that, and I'm also not sure I want to since I think that the generation shouldn't need to know this... I may be wrong though.
That’s pretty much what I was thinking too. Asking a generation for its Generation::Type smells a lot like asking it for its level.
> New version:
> http://cr.openjdk.java.net/~jwilhelm/8077842/webrev.05/
>
> Increment:
> http://cr.openjdk.java.net/~jwilhelm/8077842/webrev.05.incremental/
Looks good.
More information about the hotspot-gc-dev
mailing list