RFR (M) 8075210: Refactor strong root processing in order to allow G1 to evolve separately from GenCollectedHeap

[Erik Helin]

On 2015-03-18, Mikael Gerdin wrote:
> Hi Erik,
> 
> On 2015-03-17 16:56, Erik Helin wrote:
> >On 2015-03-16, Mikael Gerdin wrote:
> >>Full webrev:
> >>http://cr.openjdk.java.net/~mgerdin/8075210/full/webrev
> >
> >In general, the patch looks good, thanks for refactoring this!
> >
> >I agree with Thomas' comments and also have one of my own: it looks like
> >G1RootProcessor::_trace_metadata only is used by
> >G1RootProcessor::evacuate_roots, could trace_metadata become an
> >parameter to G1RootProcessor::evacuate_roots instead of being a
> >paramater to the constructor?
> 
> Excellent suggestion!
> 
> Incremental webrev at:
> http://cr.openjdk.java.net/~mgerdin/8075210/eriks-comments/webrev/

Looks good, the changes you made based on Thomas comments also looks
good. Reviewed.

Thanks,
Erik

> >
> >Also, since set_n_termination has been removed from SharedHeap, can't we
> >just remove it from G1CollectedHeap as well?
> 
> I've removed it in a previous patch (thomas-comments/webrev)
> 
> /Mikael
> 
> >
> >Thanks,
> >Erik
> >