RFR (M) 8075210: Refactor strong root processing in order to allow G1 to evolve separately from GenCollectedHeap
Thomas Schatzl
thomas.schatzl at oracle.com
Wed Mar 18 12:28:24 UTC 2015
Hi Mikael,
On Tue, 2015-03-17 at 17:00 +0100, Mikael Gerdin wrote:
> On 2015-03-17 15:26, Thomas Schatzl wrote:
> > Hi Mikael,
[...]
> >
> > - I think the instantiation of G1RootsProcessor in
> > G1CollectedHeap::verify() should be scoped, i.e. it and the call to
> > process_all_roots() enclosed with braces.
>
> Fixed.
>
Wrong indentation of the &blobsl parameter. I do not need to re-review
that.
[...]
>
> Here's an incremental webrev incorporating your suggestions:
> http://cr.openjdk.java.net/~mgerdin/8075210/thomas-comments/webrev/
> It's based on
> http://cr.openjdk.java.net/~mgerdin/8075210/done_with_threads/webrev/
> which incorporates Eric's renaming request.
>
> New full webrev at:
> http://cr.openjdk.java.net/~mgerdin/8075210/full2/webrev/
Looks good.
Thomas
More information about the hotspot-gc-dev
mailing list