RFR: 8075803: Fix GC includes and forward declarations

[Stefan Karlsson]

On 2015-03-24 16:30, Per Liden wrote:
> Looks good!

Thanks, Per!

StefanK

>
> /Per
>
> On 2015-03-24 14:03, Stefan Karlsson wrote:
>> Hi,
>>
>> Please review this patch to fix some includes and forward declarations
>> of GC specific files and types. These issues were found while working on
>> a patch to restructure parts of the oop_oop_iterate code.
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01
>> https://bugs.openjdk.java.net/browse/JDK-8075803
>>
>> A list of the the changes:
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/gc_implementation/concurrentMarkSweep/compactibleFreeListSpace.hpp.udiff.html 
>>
>>
>>
>> - Missing forward declarations
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp.udiff.html 
>>
>>
>>
>> - Missing forward declarations
>> - Missing include of cmsOopClosures.hpp
>>   - Uses MetadataAwareOopsInGenClosure
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/gc_implementation/g1/concurrentMark.hpp.udiff.html 
>>
>>
>>
>> - Missing forward declarations
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp.udiff.html 
>>
>>
>>
>> - Missing forward declarations
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/gc_implementation/parNew/parNewGeneration.hpp.udiff.html 
>>
>>
>>
>> - Missing include of parNewGeneration.hpp
>>   - Uses ParScanClosure
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/gc_implementation/parNew/parOopClosures.inline.hpp.udiff.html 
>>
>>
>>
>> - Missing include of genOopClosures.inline.hpp
>>   -- Uses OopsInKlassOrGenClosure::do_klass_barrier
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp.udiff.html 
>>
>>
>>
>> - Missing include of parallelScavengeHeap.hpp
>>   - Using ParallelScavengeHeap
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/oops/cpCache.cpp.udiff.html 
>>
>>
>>
>> - Unnecessary include of psPromotionManager.hpp
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.hpp.udiff.html 
>>
>>
>>
>> - Unnecessary include of markSweep.inline.hpp
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp.udiff.html 
>>
>>
>>
>> - Unnecessary include of markSweep.hpp
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/gc_implementation/shared/markSweep.hpp.udiff.html 
>>
>>
>>
>> - Unnecessary include of universe.hpp
>>
>> - Missing include of genOopClosure.hpp
>>   - Uses OopsInGenClosure
>>
>> - Missing include of iterator.hpp
>>   - Uses ExtendedOopClosure
>>
>> - Moved PreservedMark functions from markSweep.hpp into markSweep.cpp
>>   - Needed to get rid of warning about adjust_pointer being used but not
>> defined.
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/memory/space.cpp.udiff.html 
>>
>>
>>
>> - Unnecessary include of markSweep.hpp
>>
>>
>> http://cr.openjdk.java.net/~stefank/8075803/webrev.01/src/share/vm/memory/defNewGeneration.inline.hpp.udiff.html 
>>
>>
>>
>> - Missing include of collectedHeap.hpp
>>   - Uses CollectedHeap
>>
>> - Missing include of genOopClosures.inline.hpp
>>   - Uses ScanWeakRefClosure::do_oop_nv
>>
>> Thanks,
>> StefanK