[8u60] RFR of backport for 8067469: G1 ignores AlwaysPreTouch
Mikael Gerdin
mikael.gerdin at oracle.com
Thu Mar 26 08:35:47 UTC 2015
On 2015-03-25 22:31, Thomas Schatzl wrote:
> Hi all,
>
> can I have reviews for the backport of "8067469: G1 ignores
> AlwaysPreTouch" for 8u60?
>
> It did only apply with minor changes, so I need re-reviews. The problem
> is that JDK-8062063 that has been pushed later has already been
> backported to 8u.
>
> Note that this change is based on "8067655: Clean up G1 remembered set
> oop iteration" which is also out for review, and "8049536:
> os::commit_memory on Solaris uses alignment_hint as page size" which
> applied cleanly (hence no RFR for that one).
I have some sort of recollection that 8049536 causes some regression
with large pages, but I may be misremembering.
Erik, do you remember?
>
> Full 8u60 changeset:
> http://cr.openjdk.java.net/~tschatzl/8067469-8u60/webrev.8u60/
> Diff changest:
> http://cr.openjdk.java.net/~tschatzl/8067469-8u60/webrev.8u60-fix/
The backport looks good.
/Mikael
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8067469
> Original change:
> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/d87c2d9c1eb4
>
> Testing: jprt
>
> Thanks,
> Thomas
>
>
>
>
More information about the hotspot-gc-dev
mailing list