Request for review (s) : 8017462: G1: guarantee fails with UseDynamicNumberOfGCThreads

[Bengt Rutisson]

On 31/03/15 00:40, Jon Masamitsu wrote:
> I'm moving  Bengt's question about using @requires into
> its own thread because it deserves it.

Good idea, Jon!

And for now I think your changes are good to push. If the @requires 
discussion comes to any conclusion we can always update the test later on.

Thanks,
Bengt

>
> On 03/30/2015 04:03 AM, Bengt Rutisson wrote:
>>
>>
>>
>>>
>>>>
>>>> I guess this is a more general question. Should we use @requires to 
>>>> avoid running the same test many times or should we only use it 
>>>> when the test actually requires a specific GC configuration?
>>>
>>> I'll happily take guidance on this point.   Only using it when tests 
>>> actually requires a specific
>>> GC sounds OK.
>>
>> I'm also not sure, so my question was really a question. Is this how 
>> we want to make sure that a generic test is only run once? There are 
>> other ways...test groups, nightly batch configuration etc...
>
> I like that @requires is local to the test so easy to change. Also 
> that it
> works for JPRT when JPRT runs the jtreg tests.
>
> Jon
>