[8u60] Bulk backport for eager reclaim of humongous objects
Kim Barrett
kim.barrett at oracle.com
Sat May 9 22:23:12 UTC 2015
On May 8, 2015, at 11:23 AM, Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com> wrote:
>
> Kim Barrett skrev den 8/5/15 16:56:
>> On May 8, 2015, at 10:00 AM, Jesper Wilhelmsson <jesper.wilhelmsson at oracle.com> wrote:
>>>
>>> Looks good!
>>
>> Thanks for reviewing.
>>
>>> One question,
>>>
>>> In 8069367 you add the new test to TEST.groups:
>>>
>>> 134 hotspot_gc = \
>>> 135 sanity/ExecuteInternalVMTests.java \
>>> 136 -gc/g1/TestGreyReclaimedHumongousObjects.java
>>>
>>> I haven't seen tests with a - in front of them in TEST.groups before. Is that intentional?
>>
>> It’s used for exclusion. For 8u60, it doesn’t actually matter; the test in question wouldn’t be included
>> anyway, since 8067115: "Add jtreg gc tests to Hotspot JPRT jobs” hasn’t been backported. The test
>> is excluded from the hotspot testset because it is somewhat of a stress test, running for a while and
>> making sure nothing bad happens.
>>
>> Hm. That syntax is used quite a bit in JDK9, but the only occurrences I see in JDK8 are for sublists.
>> I’ll take a careful look at a jprt -testset hotspot run and make sure there isn’t anything surprising.
>
> Ok. As long as you know what you're doing I'm fine with the change :)
> /Jesper
I looked, and there were no surprises in the log.
More information about the hotspot-gc-dev
mailing list