Fwd: Re: Request for Review (s) - 8135318: CMS wrong max_eden_size for check_gc_overhead_limit

[Jon Masamitsu]

Forwarding to list.


-------- Forwarded Message --------
Subject: 	Re: Request for Review (s) - 8135318: CMS wrong max_eden_size 
for check_gc_overhead_limit
Date: 	Wed, 4 Nov 2015 18:59:17 +0100
From: 	Volker Simonis <volker.simonis at gmail.com>
To: 	Jon Masamitsu <jon.masamitsu at oracle.com>



Hi Jon,

the change looks good.

Thanks,
Volker

PS: ..and sorry for the extra 'h' in your name in my last mail - I apologize.

On Wed, Nov 4, 2015 at 6:47 PM, Jon Masamitsu <jon.masamitsu at oracle.com> wrote:
>
> On 11/4/2015 9:27 AM, Volker Simonis wrote:
>>
>> Hi John,
>>
>> could you please add noreg-hard label to the bug. I think that should
>> be fine for this simple fix.
>>
>> The problem is that for the bug to manifest, all the young spaces must
>> have exactly the same size. But that's hard to achieve because on the
>> command line we can only give the ratio between the various regions.
>> In reality, the actual size is computed from the ratio but rounded
>> such that exact equality is not guaranteed.
>
>
> Done.
>
> I still need one more review on this.
>
> Jon
>
>
>
>>
>> Thank you and best regards,
>> Volker
>
>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20151104/cb9fb9f7/attachment.htm>