RFR: 8141654: Tests missing -XX:+UnlockDiagnosticVMOptions
Kim Barrett
kim.barrett at oracle.com
Mon Nov 9 03:52:34 UTC 2015
On Nov 8, 2015, at 7:47 AM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
>
>
> Hi Kim,
>
> On 2015-11-07 22:09, Kim Barrett wrote:
>> Please review this fix of a couple of tests that use diagnostic
>> options without also providing -XX:+UnlockDiagnosticVMOptions.
>>
>> CR:
>> 8141654: Tests missing -XX:+UnlockDiagnosticVMOptions
>>
>> Webrev:
>> 8141654: Tests missing -XX:+UnlockDiagnosticVMOptions
>
> I assume this is the correct webrev link?
> http://cr.openjdk.java.net/~kbarrett/8141654/webrev.00/
Oops, yes, that’s the one.
> In that case it looks good.
Thanks.
> Not sure that it is such a great idea that UnlockDiagnosticVMOptions is true in debug builds. It kind of encourages mistakes like this. But that is a different story.
Agreed.
More information about the hotspot-gc-dev
mailing list