RFR (s): 8143252: Clean up G1CollectedHeap interface
Per Liden
per.liden at oracle.com
Thu Nov 19 09:15:27 UTC 2015
Hi Derek,
On 2015-11-19 06:01, Derek White wrote:
> This is a small cleanup that:
>
> * Deletes an undefined method declaration
> G1CollectedHeap::collected_locked()
> * Renames method to be more descriptive:
> G1CollectedHeap::do_collection() ---> do_full_collection()
> * Removes unused parameter "word_size" from (newly renamed)
> do_full_collection() and resize_if_necessary_after_full_collection()
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8143252
> Webrev: http://cr.openjdk.java.net/~drwhite/8143252/webrev.01/
Since you changing the argument list here, please also turn
1479 void
1480 G1CollectedHeap::
1481 resize_if_necessary_after_full_collection() {
into
1479 void G1CollectedHeap::resize_if_necessary_after_full_collection() {
Other than that the change looks good. I don't need to see another
webrev with the above fixed.
cheers,
/Per
>
> Ran jprt.
>
> Thanks!
>
> - Derek
More information about the hotspot-gc-dev
mailing list