RFR: JDK-8139293: TestGCEventMixedWithG1ConcurrentMark.java fails after JDK-8134953

[Bengt Rutisson]

Hi Jesper,

On 2015-10-09 20:23, Jesper Wilhelmsson wrote:
> Den 9/10/15 kl. 20:05, skrev Bengt Rutisson:
>>
>> Hi Eric,
>>
>> Thanks for looking at this!
>>
>> On 2015-10-09 18:37, Eric Caspole wrote:
>>> Hi Bengt, just a couple things:
>>>
>>> gcId.cpp:
>>>   68   _previous_gc_id = GCId::current(); // will assert that the GC 
>>> Id is not
>>> undefinied
>>>
>>> is misspelled ;)
>>
>> Good catch! :) I'll fix that.
>>
>>>
>>>
>>> concurrentMarkThread.cpp:
>>>  112     assert(GCId::current() != GCId::undefined(), "GC id should 
>>> have been
>>> set up in G1CollectedHeap::register_concurrent_cycle_start");
>>>
>>> Given our massive frequent refactoring I wonder if this very 
>>> specific assert
>>> text going to be accidentally stale in 6 months? It's up to you.
>>
>> Agreed. How about I change the text to:
>>
>> "GC id should have been set up by the initial mark GC."
>
> With these changes it looks good.
> Reviewed.

Thanks, Jesper!

I'll push this now to see if it makes it in before the nightly testing 
starts.

Bengt

> /Jesper
>
>>
>>>
>>> Otherwise looks good.
>>
>> Great! Thanks!
>>
>> Bengt
>>
>>> Eric
>>>
>>>
>>> On 10/09/2015 11:35 AM, Bengt Rutisson wrote:
>>>>
>>>> Hi everyone,
>>>>
>>>> Could I have a couple of reviews for this fix for a nightly failure?
>>>>
>>>> http://cr.openjdk.java.net/~brutisso/8139293/webrev.00/
>>>> https://bugs.openjdk.java.net/browse/JDK-8139293
>>>>
>>>> G1 young GCs initiate the concurrent marking cycle. Events sent to
>>>> indicate the concurrent cycle start should use the concurrent thread's
>>>> GC id not the young GC thread's id.
>>>>
>>>> Thanks,
>>>> Bengt
>>