RFR (XXS): 8138752: G1CollectorPolicy::should_should_update_surv_rate_group_predictors() uses wrong predicate

[Thomas Schatzl]

Hi Derek,

On Thu, 2015-10-08 at 16:58 -0400, Derek White wrote:
> On 10/2/15 8:54 AM, Thomas Schatzl wrote:
> 
> > Hi all,
> > 
> >   can I have reviews for this very-small fix for a bug introduced in
> > JDK-7097567?
> > 
> > Instead of using
[...]

> > bool should_propagate() { // XXX should have a more suitable state name or abstraction for this
> >    return (_last_young_gc && !_in_marking_window);
> > }
> Ahh, when I ported Ramki's original patch he had:
>     return (_last_young_gc_full && !_in_marking_window);
> 
> But the variable "_last_young_gc_full" no longer exists. I
> miss-updated that to "_last_young_gc", and didn't catch it in the
> diff.
> 
> I really need to rename these variables like I've been threatening to.
> They are very confusing!

Agree. That code needs to be cleaned up a lot.

> (r)eviewed.

Thanks for the review,
  Thomas