RFR: Remove 5 more develop options from GC code.

Eric Caspole eric.caspole at oracle.com
Wed Oct 21 14:23:09 UTC 2015


Hi David,
Always great to erase a lot of code. I just have one comment about 
updating the comments near here since UseAsyncConcMarkSweepGC is gone:

in concurrentMarkSweepGeneration.cpp

1758     if (_foregroundGCIsActive) {
1759       // The foreground collector is active or we're
1760       // not using asynchronous collections.  Skip this
1761       // background collection.

Regards,
Eric


On 10/21/2015 07:53 AM, David Lindholm wrote:
> Jesper,
>
> Thanks for the review! Could I have one more reviewer looking at this?
>
>
> Thanks,
> David
>
> On 2015-10-20 22:48, Jesper Wilhelmsson wrote:
>> Looks good!
>> Thanks for removing flags!!!
>> /Jesper
>>
>> Den 20/10/15 kl. 11:54, skrev David Lindholm:
>>> Hi,
>>>
>>> Please review this patch that removes the following 5 develop options
>>> from the
>>> GC code:
>>>
>>> UseCMSAdaptiveFreeLists
>>> UseAsyncConcMarkSweepGC
>>> CMSDictionaryChoice
>>> CMSOverflowEarlyRestoration
>>> CMSTestInFreeList
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8139952
>>> Webrev: http://cr.openjdk.java.net/~david/JDK-8139952/webrev.00/
>>>
>>>
>>> Thanks,
>>> David
>



More information about the hotspot-gc-dev mailing list