RFR: 8139149: Split G1 evacuate_collection_set into multiple steps

Erik Helin erik.helin at oracle.com
Tue Oct 27 11:41:38 UTC 2015


On 2015-10-27, Thomas Schatzl wrote:
> Hi,
> 
> On Tue, 2015-10-27 at 12:27 +0100, Mikael Gerdin wrote:
> > Hi Erik,
> > 
> > On 2015-10-27 12:19, Erik Helin wrote:
> > > Hi Mikael,
> > >
> > > thanks for doing this tricky but very appreciated patch! It is really
> > > hard to verify that there are no dependencies between the moved lines,
> > > but after staring at the code for quite some time, I think the patch is
> > > good to go. Reviewed.
> > 
> > I did get some feedback from Thomas to avoid the _ext method and instead 
> > make the external implementation responsible for calling the standard 
> > evacuate_colletion_set, as in:
> > 
> > http://cr.openjdk.java.net/~mgerdin/8139149/webrev.0_to_1/
> > http://cr.openjdk.java.net/~mgerdin/8139149/webrev.1
> > 
> 
>   looks better to me.

I'm fine with this version as well.

Thanks,
Erik

> Thanks,
>   Thomas
> 
> 



More information about the hotspot-gc-dev mailing list