RFR: JDK-8141037: Remove _MARKING_VERBOSE_ from the G1 code

Kim Barrett kim.barrett at oracle.com
Fri Oct 30 19:04:49 UTC 2015


I should have read further ahead.  I see that you already mentioned that
G1MarkingVerboseLevel is going away later.

So this change looks good.

----- Original Message -----
From: kim.barrett at oracle.com
To: bengt.rutisson at oracle.com
Cc: hotspot-gc-dev at openjdk.java.net
Sent: Friday, October 30, 2015 3:03:01 PM GMT -05:00 US/Canada Eastern
Subject: Re: RFR: JDK-8141037: Remove _MARKING_VERBOSE_ from the G1 code

> This is a fix, which is very similar to "JDK-8140781: Remove 
> _MARKING_STATS_ from the G1 code".
>
> http://cr.openjdk.java.net/~brutisso/8141037/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8141037

Name and description of G1MarkingVerboseLevel seem wrong now.
Do we even need that (develop) option any more?  After this change it
is only used to control whether ConcurrentMark::print_stats is a nop
or instead calls print_stats on each of its tasks.  Is there perhaps
some other variable more appropriate for controlling task stats printing?

Other than that, looks good.



More information about the hotspot-gc-dev mailing list