RFR (XXS): 8134856: Incorrect use of PLAB::min_size() in MaxPLABSizeBounds

[sangheon.kim]

Hi Thomas,

Thank you for fixing this!

One question for the test.
If we set 'G1HeapRegionSize=1M' and 'YoungPLABSize=2M', error message 
comes from the constructor of G1CollectorPolicy.
     jio_snprintf(buffer, sizeof(buffer), "%sPLABSize should be at most 
" SIZE_FORMAT,
                  OldPLABSize > region_size ? "Old" : "Young", region_size);
So VM exits before going to the command-line validation (i.e. 
MaxPLABSizeBounds() ) routines.
Am I missing something?

Thanks,
Sangheon


On 09/01/2015 08:59 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this small change that fixes some error message
> when you specify a too large Young- or OldPLABSize?
>
> Instead of printing the maximum PLAB size, the error message contains
> the minimum PLAB size.
>
> The change is just one line, but the test is a bit longer.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8134856
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8134856/webrev/
> Testing:
> jprt
>
> Thanks,
>    Thomas
>
>