RFR (XXS): 8134858: Remove G1 specific checking of Young/OldPLABSize in G1CollectorPolicy constructor

sangheon.kim sangheon.kim at oracle.com
Tue Sep 1 17:01:24 UTC 2015


Hi Thomas,

Not a code review but one thing to note regarding description of this CR:
Command-line validation for PLAB related flags are done after creating 
heap instances.
i.e. validation by 8078555 will be happen after creating G1CollectorPolicy.

Thanks,
Sangheon


On 09/01/2015 04:11 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this small change that removes obsolete code?
>
> JDK-8078555 added validation of Young/OldPLABSize values, and also the
> bounds used here (raw region word size) are wrong.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8134858
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8134858/webrev/
> Testing:
> jprt
>
> Thanks,
>    Thomas
>
>




More information about the hotspot-gc-dev mailing list