RFR: JDK-8133818: Additional number of processed references printed with -XX:+PrintReferenceGC after JDK-8047125
Thomas Schatzl
thomas.schatzl at oracle.com
Wed Sep 2 09:43:36 UTC 2015
Hi Bengt,
On Wed, 2015-09-02 at 11:20 +0200, Bengt Rutisson wrote:
> Hi Thomas,
>
> Thanks for looking at this!
>
> On 01/09/15 19:02, Thomas Schatzl wrote:
> > On Tue, 2015-09-01 at 14:54 +0200, Bengt Rutisson wrote:
> >> Hi everyone,
> >>
> >> Could I have a couple of reviews for this patch contributed by Ramki?
> >>
> >> http://cr.openjdk.java.net/~brutisso/8133818/webrev.00/
> >> https://bugs.openjdk.java.net/browse/JDK-8133818
> >>
> > jvmtiTagMap.cpp, line 3408: the SIZE_FORMAT specifiers need a space
> > before and after, otherwise it will not compile with newer C++
> > compilers. Same for referenceProcessor.cpp, 307,
> >
> > jvmtiTagMap.hpp, line 125: please fix the format of the method parameter
> > specifications.
> >
> > In general I would be really happy if there were a test checking the
> > output of -XX:+TraceReferenceGC. If we had had that earlier, this issue
> > would have not cropped up, and prevents future issues.
> >
> > I.e. just the format of "[whateverreference, <bb> refs, <cc> secs] ....
> > [PhantomReference, <xx> refs, <yyy> secs] ... [Cleaners, <zz> refs,
> > <aaa> secs] .."
>
> Good points.
>
> Here's an updated webrev:
> http://cr.openjdk.java.net/~brutisso/8133818/webrev.01/
>
> Diff compared to the last version:
> http://cr.openjdk.java.net/~brutisso/8133818/webrev.00-01.diff/
looks good. The test is just like I imagined, thanks a lot.
Thanks,
Thomas
More information about the hotspot-gc-dev
mailing list