FWD: RFR: 8134626 - Misc cleanups after generation array removal

[David Holmes]

Looks good.

Thanks,
David

On 5/09/2015 1:07 AM, Jesper Wilhelmsson wrote:
> Hi David,
>
> Thanks for reviewing!
>
> I fixed the division and the copyright headers. There are also a few
> changes pointed out by Thomas.
>
> An updated version is available here:
>
> http://cr.openjdk.java.net/~jwilhelm/8134626/webrev.01/
>
> In addition to the tree parts there is a diff showing what changed from
> the last webrev. I guess this is the one you want to look at ;)
>
> http://cr.openjdk.java.net/~jwilhelm/8134626/webrev.01/increment/
>
> Thanks,
> /Jesper
>
>
> Den 4/9/15 kl. 06:38, skrev David Holmes:
>> Hi Jesper,
>>
>> I didn't see any responses to this yet ...
>>
>> On 31/08/2015 11:56 PM, Jesper Wilhelmsson wrote:
>>> Hi runtime,
>>>
>>> While working with the generation array removal I did a bunch of
>>> unrelated cleanups in the code I passed by. I split this out into a
>>> separate patch to keep the other changes clean.
>>>
>>> This is mostly GC code, but a few runtime files was touched as well and
>>> might cause merge conflicts with your favorite local repository, so I
>>> was advised to forward this RFR to the runtime list as well.
>>>
>>>
>>> This change is split into three webrevs to make it easier to review. I
>>> intend to push all three as one change.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8134626
>>>
>>>
>>> Increment 1: Renaming
>>> http://cr.openjdk.java.net/~jwilhelm/8134626/webrev.00/inc1-renaming/
>>>
>>> Changes the variable name gen to young_gen or old_gen depending on
>>> what the
>>> variable will contain. The few cases where the name gen is untouched are
>>> places where the variable actually can contain either generation.
>>
>> Looks okay.
>>
>> src/share/vm/services/memoryPool.hpp
>> src/share/vm/services/psMemoryPool.cpp
>>
>> need copyright updates.
>>
>>> Increment 2: Comments and indentation
>>> http://cr.openjdk.java.net/~jwilhelm/8134626/webrev.00/inc2-comments_and_indentation/
>>>
>>>
>>>
>>>
>>> * Fixes up alignment in lots of places.
>>> * Inserts and removes empty lines where needed.
>>> * Cleans up comments where we previously talked about older and younger
>>> generations. Fixes a few typos and clarifies some comments with
>>> respect to
>>> young/old generations and collections.
>>> * Added spaces around some operators.
>>
>> src/share/vm/gc/cms/concurrentMarkSweepGeneration.cpp
>>
>>   _bootstrap_occupancy = ((double)CMSBootstrapOccupancy) / (double)100;
>>
>> is simpler as:
>>
>>   _bootstrap_occupancy = CMSBootstrapOccupancy / 100.0;
>>
>>
>> src/share/vm/services/psMemoryPool.cpp needs copyright update
>>
>> Otherwise seems ok.
>>
>>>
>>> Increment 3: Code changes
>>> http://cr.openjdk.java.net/~jwilhelm/8134626/webrev.00/inc3-code_changes/
>>>
>>>
>>> * Merged strings that was split on several lines for no good reason.
>>> * Added braces for if statements and for loops.
>>> * Removed dead code.
>>> * Moved variable initialization to initializer list in CollectedHeap
>>> constructor.
>>> * Updated flag descriptions "youngest" -> "young".
>>
>> All looks fine to me.
>>
>> Thanks,
>> David
>>
>>> Thanks,
>>> /Jesper
>>>
>>>
>>>