RFR: 8134797: Remove explicit casts in CollectorPolicy hierarchy

Kim Barrett kim.barrett at oracle.com
Tue Sep 8 18:42:52 UTC 2015


On Sep 3, 2015, at 7:27 AM, Per Liden <per.liden at oracle.com> wrote:
> 
>> The alternative to moving the collector_policy definition was to add an
>> #include of g1CollectorPolicy.hpp to g1CollectedHeap.hpp.
> 
> Sorry, yes, that's what I mean, but I looked at the wrong dependency chain.
> 
>> 
>> Since collector_policy is a virtual function, and we don’t have C++ final specifiers,
>> I don’t think it is a likely candidate for inlining, so I moved it to the .cpp file.
>> 
> 
> I'm fine with either approach. Inlining isn't a concern here.

OK.  Thanks for looking at this.




More information about the hotspot-gc-dev mailing list