RFR (S): 8135025: Error message is repeated for large value at G1ConcRefinementThreads

[Kim Barrett]

On Sep 8, 2015, at 3:28 PM, sangheon.kim <sangheon.kim at oracle.com> wrote:
> 
> Hi all,
> 
> After some discussion, I decided to propose this webrev.01 version which has different style from webrev.00.
> 
> The difference is to add public factory function and privatize the constructor.
> So that newly added 'public bool initialize_threads() (from webrev.00)' is not needed.
> With this approach we can minimize public function and handle the error situation correctly.
> 
> Can I get some reviews for this?
> http://cr.openjdk.java.net/~sangheki/8135025/webrev.01/

Changes look good.  One pre-existing issue:

------------------------------------------------------------------------------ 
src/share/vm/gc/g1/concurrentG1Refine.cpp
  66   cg1r->_threads = NEW_C_HEAP_ARRAY(ConcurrentG1RefineThread*, cg1r->_n_threads, mtGC);

It seems like this should be using NEW_C_HEAP_ARRAY_RETURN_NULL, check
for NULL, and do the failure dance and error return.  That would be
consistent with the other nearby allocations.

------------------------------------------------------------------------------