RFR: JDK-8136991: [REDO] Additional number of processed references printed with -XX:+PrintReferenceGC after JDK-8047125

Bengt Rutisson bengt.rutisson at oracle.com
Wed Sep 23 08:32:26 UTC 2015


Hi Stefan,

Thanks for looking at this!

On 2015-09-23 10:26, Stefan Karlsson wrote:
> Hi Bengt,
>
> On 2015-09-23 09:21, Bengt Rutisson wrote:
>>
>> Hi everyone,
>>
>> Could I have a couple of reviews for this change?
>>
>> http://cr.openjdk.java.net/~brutisso/8136991/webrev.02/
>
> As we've discussed offline, your new GCRefTraceTime uses aggregation 
> and the pre-exisiting G1CMTraceTime uses inheritance. I'd prefer if we 
> could use the same model for both classes.

The updated webrev that I sent in the reply to Thomas contains the same 
change to G1CMTraceTime as I did for GCRefTraceTime. I also made 
GCTraceTime a StackObj.

Thanks,
Bengt

>
> Thanks,
> StefanK
>
>> https://bugs.openjdk.java.net/browse/JDK-8136991
>>
>> Background:
>>
>> The original change for this issue was more extensive in its changes 
>> to the log and tracing output. This caused some issues with our 
>> internal testing. This new change only tries to address the double 
>> "ref count" logging for PhantomReferences.
>>
>> Thanks,
>> Bengt
>




More information about the hotspot-gc-dev mailing list