RFR: JDK-8136991: [REDO] Additional number of processed references printed with -XX:+PrintReferenceGC after JDK-8047125

[Bengt Rutisson]

Forgot to say that there is a diff compared to the previous version here:
http://cr.openjdk.java.net/~brutisso/8136991/webrev.02-03-diff/

Bengt

On 2015-09-23 10:31, Bengt Rutisson wrote:
>
> Hi Thomas,
>
> On 2015-09-23 09:45, Thomas Schatzl wrote:
>> Hi Bengt,
>>
>> On Wed, 2015-09-23 at 09:21 +0200, Bengt Rutisson wrote:
>>> Hi everyone,
>>>
>>> Could I have a couple of reviews for this change?
>>>
>>> http://cr.openjdk.java.net/~brutisso/8136991/webrev.02/
>>> https://bugs.openjdk.java.net/browse/JDK-8136991
>>>
>>> Background:
>>>
>>> The original change for this issue was more extensive in its changes to
>>> the log and tracing output. This caused some issues with our internal
>>> testing. This new change only tries to address the double "ref count"
>>> logging for PhantomReferences.
>>    some comments:
>>
>> - could we keep the test that checks PrintReferenceGC output back from
>> the original change?
>>
>> - I would somewhat prefer if "reference_type_to_compact_string" were
>> called "reference_type_to_short_string", as the existing code uses
>> "short_str[ing]" for returning a "short" purpose. It's not a big deal if
>> you keep it as is. Its result is not really a short string anyway.
>>
>> - maybe some future change/CR could calculate the JNI weak ref count
>> during iteration and it could be printed always.
>>
>> Looks okay otherwise.
>
> Thanks for looking at this!
>
> All goo points. Here's an updated webrev:
> http://cr.openjdk.java.net/~brutisso/8136991/webrev.03/
>
> It also contains the changes that StefanK suggested.
>
> Thanks,
> Bengt
>
>>
>> Thanks,
>>    Thomas
>>
>>
>