RFR (XXS): 8154141: [TESTBUG] test/gc/g1/TestRegionLivenessPrint.java misses -XX:+UnlockDiagnosticVMOption flag

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Wed Apr 13 12:58:06 UTC 2016


Hi Thomas,

The change looks good. But one thing: you don't need to list 8154141 in 
the @bug.
The purpose of @bug is to help finding an origin why the test was developed.

Thanks for the prompt fix.
Dima


On 13.04.2016 15:30, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this tiny issue? The test mentioned does not
> have -XX:+UnlockDiagnosticVMOptions in its @run line, so it does not
> always work.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8154141
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8154141/webrev/
> Testing:
> local testing
>
> Thanks,
>    Thomas
>




More information about the hotspot-gc-dev mailing list