Fwd: Re: RFR: 8133051: Concurrent refinement threads may be activated and deactivated at random

[Derek White]

[Resend to correct email list]


-------- Forwarded Message --------
Subject: 	Re: RFR: 8133051: Concurrent refinement threads may be 
activated and deactivated at random
Date: 	Fri, 15 Apr 2016 13:12:28 -0400
From: 	Derek White <derek.white at oracle.com>



On 4/12/16 2:31 PM, Kim Barrett wrote:
>> On Apr 4, 2016, at 2:48 PM, Kim Barrett<kim.barrett at oracle.com>  wrote:
>>
>> Please review this change to the G1 concurrent refinement thread
>> controller.  This change addresses unnecessary activation when there
>> are many threads and few buffers to be processed.  It also addresses
>> delayed activation due to mis-configuration of the dirty card queue
>> set's notification mechanism.
> I had been hoping I might come back from vacation and find some reviews waiting for me to look at.
>
Hi Kim,

Looks good.

My final comment:

src/share/vm/gc/g1/concurrentG1Refine.cpp:

- In ConcurrentG1Refine::create(), around line 188, it would be nice to 
log number "max number of concurrent refinement threads" (aka 
thread_num() aka _n_worker_threads).

- Derek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20160415/becdec05/attachment.htm>