RFR(S): 8164028: Convert TestPredictions_test to GTest

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Wed Aug 17 15:52:01 UTC 2016


Jesper,

Thank you for reviewing the fix!

I changed lines you requested.

Here are a new WebRev: 
http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8164028/webrev.01/

Regards, Kirill

On 17.08.2016 16:13, Jesper Wilhelmsson wrote:
> Looks good!
>
> If you don't mind changing it, I would prefer if lines 40, 44, and 51 
> was moved up to the previous lines. The lines would be slightly longer 
> but the code would be easier to read imho.
>
> Thanks,
> /Jesper
>
>
> Den 17/8/16 kl. 14:42, skrev Kirill Zhaldybin:
>> Dear all,
>>
>> Could you please review this fix for JDK-8164028?
>>
>> The test was converted to gtrest, a couple of wrong checks fixed.
>>
>> WebRev: 
>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8164028/webrev.00/
>> CR: https://bugs.openjdk.java.net/browse/JDK-8164028
>>
>> Thank you.
>>
>> Regards, Kirill




More information about the hotspot-gc-dev mailing list