RFR(S): 8164039: Convert test_memset_with_concurrent_readers to GTest

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Wed Aug 17 18:35:16 UTC 2016


Igor,

Thank you for review!

Regards, Kirill

On 17.08.2016 21:25, Igor Ignatyev wrote:
> Hi Kirill,
>
> thanks for fixing that. Reviewed.
>
> — Igor
>> On Aug 16, 2016, at 8:44 PM, Kirill Zhaldybin <kirill.zhaldybin at oracle.com> wrote:
>>
>> Igor,
>>
>> Thank you for reviewing the fix!
>>
>> I changed ASSERTs to EXPECTs.
>>
>> Here are a new webrev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8164039/webrev.01/
>>
>> Regards, Kirill
>>
>> On 16.08.2016 20:18, Igor Ignatyev wrote:
>>> Hi Kirill,
>>>
>>> I think it’s better to use EXPECT_* instead of ASSERT_* in this test, so we will perform all checks in one run.
>>> otherwise the change looks good to me.
>>>
>>> — Igor
>>>
>>>> On Aug 16, 2016, at 7:44 PM, Kirill Zhaldybin <kirill.zhaldybin at oracle.com> wrote:
>>>>
>>>> Dear all,
>>>>
>>>> Could you please review this fix for JDK-8164039?
>>>>
>>>> test_memset_with_concurrent_readers was converted to GTest.
>>>>
>>>> WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8164039/webrev.00/
>>>> CR: https://bugs.openjdk.java.net/browse/JDK-8164039
>>>>
>>>> Thank you.
>>>>
>>>> Regards, Kirill




More information about the hotspot-gc-dev mailing list