RFR: 8163413: gc/metaspace/TestMetaspacePerfCounters failure

Stefan Johansson stefan.johansson at oracle.com
Mon Aug 22 13:16:04 UTC 2016


Thanks Erik,

Stefan

On 2016-08-22 14:31, Erik Helin wrote:
> On 2016-08-16, Stefan Johansson wrote:
>> Hi,
>>
>> Please review this test fix for:
>> https://bugs.openjdk.java.net/browse/JDK-8163413
>>
>> Webrev:
>> http://cr.openjdk.java.net/~sjohanss/8163413/hotspot.00/
> Looks ok, Reviewed.
>
> Thanks,
> Erik
>
>> Summary:
>> The test failure is most likely caused by getting a GC in between the calls
>> to get the perf counter values. Since the values are updated during a GC
>> this might cause the values to break the assert conditions. To avoid this my
>> fix checks the number of GCs that have been done before and after getting
>> the values and only proceeds to doing the assertions if no GC occurred.
>>
>> Testing:
>> * Verified test both locally and with RBT.
>>
>> Thanks,
>> Stefan




More information about the hotspot-gc-dev mailing list