RFR (S): 8164660: MinimalVM is not tested with GC tests
Jon Masamitsu
jon.masamitsu at oracle.com
Fri Aug 26 17:14:00 UTC 2016
Dima,
On 8/26/2016 9:43 AM, Dmitry Fazunenko wrote:
> Hello,
>
> I'm looking for reviewers for a simple change needed for better
> selection of tests applicable for minimal VM.
> There are two sort of changes:
> - removing '@modules java.management' (if it's not needed)
> - adding @requires vm.gc.X (to those tests which ignore external
> flags and keep passing even if conflicting collector is given)
I interpret that to mean that there are tests that ignore external flags
and pass even
if conflicting collectors are given. Adding vm.gc.X makes it more
certain that passing
tests really pass (that is, the tests are only run with the correct
collector and pass
because the test ran successfully and not because some external flags
were ignored).
If I read that correctly, then changes look good.
Jon
>
> https://bugs.openjdk.java.net/browse/JDK-8164660
> http://cr.openjdk.java.net/~dfazunen/8164660/webrev.00/
>
> Thanks
> Dima
More information about the hotspot-gc-dev
mailing list