RFR (S): 8164660: MinimalVM is not tested with GC tests

Thomas Schatzl thomas.schatzl at oracle.com
Mon Aug 29 08:18:34 UTC 2016


Hi Dima,

On Fri, 2016-08-26 at 19:43 +0300, Dmitry Fazunenko wrote:
> Hello,
> 
> I'm looking for reviewers for a simple change  needed for better 
> selection of tests applicable for minimal VM.
> There are two sort of changes:
> - removing '@modules java.management' (if it's not needed)
> - adding @requires vm.gc.X  (to those tests which ignore external
> flags 
> and keep passing even if conflicting collector is given)
> 
> https://bugs.openjdk.java.net/browse/JDK-8164660
> http://cr.openjdk.java.net/~dfazunen/8164660/webrev.00/


  previously tests in the hotspot/test/gc/g1 directory were excluded by
the TEST.groups file. So why do they need the @requires tag now?

TestStringSymbolTableStats.java is still missing the @requires tag
after this change.

Also, I think that none of the tests where the change adds the
@requires vm.gc.g1, needs java.management.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list