RFR(S): 8170468: Convert ParallelCompact_test to GTest

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Fri Dec 2 14:19:14 UTC 2016


Dmitry,

Thank you for review!

I will fix copyright before pushing the fix.

Regards, Kirill

On 02.12.2016 16:30, Dmitry Fazunenenko wrote:
> Kirill,
>
> The fix looks good to me, but minor nit:
> test_psParallelCompact.cpp should have the same years in the 
> copyrights as psParallelCompact.cpp: 2005, 2016,
>
> No need a separate review for that.
>
> Thanks,
> Dima
>
> On 29.11.2016 18:55, Kirill Zhaldybin wrote:
>> Dear all,
>>
>> Could you please review this fix for 8170468?
>>
>> The conversion was straight-forward but to get access to 
>> print_generic_summary_data function which was defined in cpp file 
>> without any class I needed to introduce a new method in 
>> PSParallelCompact class. Since it is private I added new friend class 
>> to get access to the method.
>> Since tested functionality is "non-product only" so are the test.
>>
>> WebRev: 
>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8170468/webrev.00/
>>
>> CR: https://bugs.openjdk.java.net/browse/JDK-8170468
>>
>> Thank you.
>>
>> Regards, Kirill
>




More information about the hotspot-gc-dev mailing list