RFR(XS): 8170490: Convert TestBufferingOopClosure_test to GTest

Kirill Zhaldybin kirill.zhaldybin at oracle.com
Fri Dec 2 16:37:30 UTC 2016


Igor,

Thank you for review!

Regards, Kirill

On 02.12.2016 19:12, Igor Ignatyev wrote:
> Hi Kirill,
>
> looks good to me, reviewed.
>
> Thanks,
> — Igor
>
>> On Dec 2, 2016, at 4:31 PM, Kirill Zhaldybin <kirill.zhaldybin at oracle.com> wrote:
>>
>> Dima,
>>
>> Thank you for review!
>>
>> Regards, Kirill
>>
>> On 02.12.2016 16:18, Dmitry Fazunenenko wrote:
>>> Hi Kirill,
>>>
>>> the fix looks good to me.
>>>
>>> Thanks,
>>> Dima
>>>
>>> On 01.12.2016 14:04, Kirill Zhaldybin wrote:
>>>> Dear all,
>>>>
>>>> Could you please review this fix for 8170490?
>>>>
>>>> Pretty straight-forward conversion, friend class name was changed to correspond other friend classes used for testing, deleted some defines we do not need.
>>>>
>>>> WebRev: http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8170490/webrev.00/
>>>> CR: https://bugs.openjdk.java.net/browse/JDK-8170490
>>>>
>>>> Thank you.
>>>>
>>>> Regards, Kirill




More information about the hotspot-gc-dev mailing list