RFR: JDK-8149542: Missing failure reporting in HeapRegion::verify

Thomas Schatzl thomas.schatzl at oracle.com
Wed Feb 10 13:26:07 UTC 2016


Hi Bengt,

On Wed, 2016-02-10 at 13:50 +0100, Bengt Rutisson wrote:
> Hi everyone,
> 
> Could I have a couple of reviews for this small change?
> 
> http://cr.openjdk.java.net/~brutisso/8149542/webrev.00/
> https://bugs.openjdk.java.net/browse/JDK-8149542
> 
> Line 830 in heapRegion.cpp should be followed by lines like this:
> 
>    *failures = true;
>    return;
> 
> http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/file/2a8e87190908/src/s
> hare/vm/gc/g1/heapRegion.cpp#l830

  looks good.

Thomas



More information about the hotspot-gc-dev mailing list