Fwd: Re: RFR: JDK-8072725: Provide more granular levels for GC verification

[Thomas Schatzl]

Hi Poonam,

On Mon, 2016-01-11 at 08:09 -0800, Poonam Bajaj Parhar wrote:
> Hello Thomas,
> 
> > Sorry for not finding this earlier, one more issue: the description
> > string of the flag in globals.hpp needs closing quotation marks at
> > the
> > end of every line. Otherwise it will contain lots of additional
> > unnecessary whitespace at the end of every "line" when printed.

The description string needs whitespace at the end of every line.
Otherwise the words at the end of a line and the first at the beginning
of the next line will not have the necessary whitespace.

E.g.

"This is a test" \
"string"

will read "This is a teststring". I think the change meant to use

"This is a test " \
"string"

> > It might be useful to add a failing test run covering specifying an
> > invalid subset.
> 
> Fixed both:
> http://cr.openjdk.java.net/~poonam/8072725/webrev.03/
> 
> Please take a look.

Please add a 

output.shouldHaveExitValue(1);

at the end of the second test.

Looks good otherwise. I do not need to re-review these two issues.

Thanks,
  Thomas